Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniform royalties #334

Merged
merged 18 commits into from
Jul 12, 2022
Merged

Uniform royalties #334

merged 18 commits into from
Jul 12, 2022

Conversation

mrsmkl
Copy link
Contributor

@mrsmkl mrsmkl commented Jul 12, 2022 •
edited

Description

Add a description of your changes here.

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

aaitor and others added 14 commits June 16, 2022 15:38
@aaitor
Adding Token name and symbol as potential parameters for ERC-721 impl…
886266e 
…ementations (#328)

* Adding Token name and symbol as potential parameters for ERC-721 implementations

* fixing tests

* typo
@mrsmkl
changed circuit build script name (#330)
9ef044b
@aaitor
Adding documentation workflow and fixing copyright (#331)
a93da60 
* Copyright adjustments

* Adding doc workflow

* linting
@aaitor
adding github token
8e685be
@alvarof2
Update push-to-docs.yml
b1cd31b
@alvarof2
Update push-to-docs.yml
2402553
@alvarof2
Update push-to-docs.yml
16849d9
@jcortejoso
Update release-github.yml
d48d18a
@jcortejoso
Merge pull request #333 from nevermined-io/jcortejoso/changelog-branch
bb3811a 
Update release-github.yml
@mrsmkl
mispelled names...
2976a86
@mrsmkl
adding name
076a04a
@mrsmkl
tests working after adding param
b665ed8
@mrsmkl
set default royalties using the standard royalties contract
b4854c9
@mrsmkl
tests working
7d3e980
@mrsmkl mrsmkl requested review from a team as code owners July 12, 2022 12:55
aaitor
aaitor approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@aaitor aaitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@mrsmkl mrsmkl merged commit 8e86f76 into develop Jul 12, 2022
@mrsmkl mrsmkl deleted the feat/uniform-royalties branch July 12, 2022 16:40
@aaitor aaitor linked an issue Jul 14, 2022 that may be closed by this pull request
Unify denominator in royalties input parameter #327
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaitor aaitor aaitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify denominator in royalties input parameter
4 participants
@mrsmkl @aaitor @alvarof2 @jcortejoso