Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOC for doc and testing push to docs #355

Merged
merged 5 commits into from
Jul 22, 2022
Merged

TOC for doc and testing push to docs #355

merged 5 commits into from
Jul 22, 2022

Conversation

aaitor
Copy link
Member

@aaitor aaitor commented Jul 22, 2022

Description

Add a description of your changes here.

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@aaitor aaitor requested review from a team as code owners July 22, 2022 16:10
Copy link
Member

@r-marques r-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aaitor aaitor merged commit e86fea5 into master Jul 22, 2022
@aaitor aaitor deleted the fix/push_to_docs branch July 22, 2022 16:45
aaitor added a commit that referenced this pull request Sep 6, 2022
* Adding nightly security analysis (#336)

* removing Kovan tests until we migrate Aave tests to `mumbai`.
See: nevermined-io/internal#230

* Adding first test

* just on push

* changed order of needs

* tests

* adding slither and mythril reports generators

* trying to generate the reports

* coming back to dir

* cd ..

* everything in the same build

* re-order

* Making this run nightly

* skipping the job

* cleanup

* setting as `markdown` knowing prints in text format

* test using 2.0.0

* test using 2.0.0

* adding upgrade cache

* fixing...

* Documentation improvements to contract deployment instructions (#341)

* Bump @openzeppelin/contracts-upgradeable from 4.6.0 to 4.7.1 (#352)

Bumps [@openzeppelin/contracts-upgradeable](https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable) from 4.6.0 to 4.7.1.
- [Release notes](https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/releases)
- [Changelog](https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/blob/master/CHANGELOG.md)
- [Commits](OpenZeppelin/openzeppelin-contracts-upgradeable@v4.6.0...v4.7.1)

---
updated-dependencies:
- dependency-name: "@openzeppelin/contracts-upgradeable"
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aitor <1726644+aaitor@users.noreply.github.com>

* manage Subscriptions duration and minting as an option in `TransferNFT721Condition` (#350)

* Adding external NFT contract address

* Adding better Subscriptions support

* linting

* adding subscription contract

* moving test to avoid using it during upgradeability

* test moved

* using subscription nft only in some tests

* Automated CHANGELOG.md update

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* changing proxy admin ownership should now work

* cleanup

* Fixed initialization of the contracts

- docker builds should now fail if the contract deployment fails

* TOC for doc and testing push to docs (#355)

* TOC for doc and testing push to docs

* order

* new test

* test

* enabling when tagging

* bumping to `v2.0.2`

* Automated CHANGELOG.md update

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* The provider should be able to mint (#358)

* The provider should be able to mint

* bumping to `v2.0.3`

* When we are using a external NFT contract is necessary to check external permissions there (#359)

and not into the default instance

* Automated CHANGELOG.md update

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* perhaps tests now work

* compiler error

* changing back

* cleanup

* Do not use widdershins on push-to-docs

* Remove npm contracts package since it's no longer needed

* Bump version to 2.0.4

* Commit latest openzeppelin files into master

* remove npm badge from readme

* Bring doc updates from develop into master

* Script for downloading artifacts from s3

* New yarn scripts for download and upload from s3

* Save openzeppelin file to s3 too

* Download openzeppelin file too

* Debug Github action push-to-docs

* Fix permissions

* Debug

* Automated CHANGELOG.md update

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Deployed 2.0.4 to mumbai common

* Some notes about problems with Upgrades

* typescript md reference

* Add cache files to gitignore

* Add yarn clean:cache script

* Upload openzeppelin file to S3

* Upload circuits when release. Fix AWS IAM login

* Updated doc

* Updated doc

* Disable Debug step

* Update push-to-docs.yml

* Fixing a problem with a collision on `tokenId` for ERC-721 minted via TransferNFT721Condition (#373)

* Mumbai Common deployment 2.0.5 (#374)

* New mumbai deployment for public 2.0.5 (#375)

Co-authored-by: Aitor <1726644+aaitor@users.noreply.github.com>

* updating snarkjs version (#382)

* updating version

* set circom version

* trying these versions ...

* changing this

* Refactoring revert error messages, implements #316 (#381)

* Refactoring revert error messages, implements #316

* fixing upgreadability test

* Adding contract metadata uri to NFT factories (#383)

* update yarn.lock

* cleanup warning

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aitor <1726644+aaitor@users.noreply.github.com>
Co-authored-by: Rodolphe Marques <marques.rodolphe@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: aaitor <aaitor@users.noreply.github.com>
Co-authored-by: Rodolphe Marques <rodolphe@keyko.io>
Co-authored-by: Javier Cortejoso <javier.cortejoso@gmail.com>
Co-authored-by: Javier Cortejoso <javi@keyko.io>
Co-authored-by: Javier Cortejoso <javi@clabs.co>
Co-authored-by: jcortejoso <jcortejoso@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants