Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testnet flag when upgrading testnets #356

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Conversation

jcortejoso
Copy link
Contributor

Description

yarn upgrade:<testnet> is not setting testnet flag for some of the public EVMS:

╰─ yarn upgrade:mumbai
yarn run v1.22.19
$ export NETWORK=mumbai&&yarn run upgrade --network mumbai
$ npx hardhat run ./scripts/deploy/truffle-wrapper/upgradeContractsWrapper.js --network mumbai
testnet false

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@jcortejoso jcortejoso requested review from a team as code owners July 25, 2022 07:05
@aaitor aaitor merged commit cefd17a into develop Jul 25, 2022
@aaitor aaitor deleted the jcortejoso-patch-1 branch July 25, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants