Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new type of DynamicAccess template #39

Merged
merged 7 commits into from
Dec 30, 2020

Conversation

aaitor
Copy link
Member

@aaitor aaitor commented Dec 30, 2020

Description

This new Access template is empty by default. Multiple instances of this template with different condition combinations can be created. It allows to have more flexibility adding support to SEA with not only the 3 classical conditions (access, lockReward, escrowReward)

As extra ball, this PR splits the CI pipeline in two parallel stages, reducing the build time from 30 to 17 minutes.

Is this PR related with an open issue?

Related to Issue #40

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ X Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

@aaitor aaitor requested review from a team as code owners December 30, 2020 10:24
Copy link
Member

@r-marques r-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aaitor aaitor merged commit a892e4b into master Dec 30, 2020
@aaitor aaitor deleted the feature/flexible_template branch December 30, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a dynamic contract template allowing to define flexible Service Execution Agreements
2 participants