Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding possibility of ERC-1155 initialization via initializeWithName method Default initialization of ERC-1155 and ERC-721 #399

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Adding possibility of ERC-1155 initialization via initializeWithName method Default initialization of ERC-1155 and ERC-721 #399

merged 3 commits into from
Oct 17, 2022

Conversation

aaitor
Copy link
Member

@aaitor aaitor commented Oct 17, 2022

Description

Add a description of your changes here.

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@aaitor
Adding possibility of ERC-1155 initialization via `initializeWithName…
8269a84 
…` method

Default initialization of ERC-1155 and ERC-721
@aaitor aaitor requested review from a team as code owners October 17, 2022 07:25
@aaitor aaitor requested a review from ssallam October 17, 2022 07:30
mrsmkl
mrsmkl approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@mrsmkl mrsmkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@aaitor aaitor merged commit 5ab1523 into master Oct 17, 2022
@aaitor aaitor deleted the feature/1155_name_symbol branch October 17, 2022 13:49
@aaitor aaitor linked an issue Oct 17, 2022 that may be closed by this pull request
Add name and symbol to ERC1155 implementation #398
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsmkl mrsmkl mrsmkl approved these changes

@ssallam ssallam Awaiting requested review from ssallam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add name and symbol to ERC1155 implementation
2 participants
@aaitor @mrsmkl