Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unnecessary setApprovalForAll to conditions because they are now managed via proxy permissions #411

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Removing unnecessary setApprovalForAll to conditions because they are now managed via proxy permissions #411

merged 1 commit into from
Nov 21, 2022

Conversation

aaitor
Copy link
Member

@aaitor aaitor commented Nov 18, 2022 •
edited

Description

Removing unnecessary setApprovalForAll to conditions because they are now managed via proxy permissions

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@aaitor aaitor requested review from a team as code owners November 18, 2022 17:55
@aaitor aaitor changed the base branch from master to develop November 18, 2022 17:56
r-marques
r-marques approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@r-marques r-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be done in the sdk also

@aaitor aaitor merged commit acb6759 into develop Nov 21, 2022
@aaitor aaitor deleted the fix/remove_approvals branch November 21, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-marques r-marques r-marques approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aaitor @r-marques