Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EscrowReward condition support for distributing different rewards to multiple addresses #42

Merged
merged 11 commits into from
Jan 28, 2021

Conversation

aaitor
Copy link
Member

@aaitor aaitor commented Jan 26, 2021

Description

This allows the implementation of the use cases where the reward can be distributed between the data publisher and a different party (marketplace, infrastructure provider, ..)

Is this PR related with an open issue?

Related to Issue https://github.com/nevermined-io/internal/issues/123

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

…multiple addresses.

This allows the implementation of the use cases where the reward can be distributed between the data publisher and a different party (marketplace, infrastructure provider, ..)
@aaitor aaitor requested review from a team as code owners January 26, 2021 16:58
Comment on lines +3 to +9
#on: [ push, pull_request ]
on: push
#on:
# push:
# pull_request:
# branches:
# - master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be:

on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]

Copy link
Member

@r-marques r-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aaitor aaitor merged commit b838b59 into master Jan 28, 2021
@aaitor aaitor deleted the feature/multiple_rewards branch January 28, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants