Adding burn capabilities to subscription NFTs #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsmkl
approved these changes
Mar 30, 2023
|
|
||
| uint256 _pendingToBurn = amount; | ||
| for (uint index = 0; index < _tokens[_key].length; index++) { | ||
| if (_pendingToBurn <= _tokens[_key][index].amountMinted) { |
There was a problem hiding this comment.
There probably should be some kind of upper limit for how many mints per key there can be. Then when they are burned or outdated, the storage slots can be reused...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The motivation of this change is to enable
burncapabilities on the subscription NFT tokens. It will allow them to work a a subscription with credit (using their balance) where tokens are consumed after usage.Is this PR related with an open issue?
Related to Issue #
Types of changes
Checklist:
Funny gif