Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating node version for gh actions #503

Merged
merged 11 commits into from
Sep 28, 2023
Merged

updating node version for gh actions #503

merged 11 commits into from
Sep 28, 2023

Conversation

mrsmkl
Copy link
Contributor

@mrsmkl mrsmkl commented Sep 20, 2023 •
edited

Description

Made some changes so that nvmConfig operators are used everywhere.
When cloning NFT contracts, now the nvmConfig is automatically set.

Other: Looks like node 16 is needed now for gh actions.

Is this PR related with an open issue?

Related to Issue #504

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@mrsmkl mrsmkl requested review from a team as code owners September 20, 2023 11:55
@mrsmkl mrsmkl merged commit 059b757 into main Sep 28, 2023
3 checks passed
@mrsmkl mrsmkl deleted the fix/node14-to-16 branch September 28, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaitor aaitor aaitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrsmkl @aaitor