Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erc 1155 token batch operations #512

Merged
merged 7 commits into from
Oct 5, 2023
Merged

Erc 1155 token batch operations #512

merged 7 commits into from
Oct 5, 2023

Conversation

mrsmkl
Copy link
Contributor

@mrsmkl mrsmkl commented Oct 4, 2023 •
edited

Description

TODO: add tests.

Is this PR related with an open issue?

Related to Issue #511

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@mrsmkl mrsmkl requested review from a team as code owners October 4, 2023 13:28
aaitor
aaitor reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@aaitor aaitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending:

  • add test
  • balanceBatch

@aaitor aaitor linked an issue Oct 5, 2023 that may be closed by this pull request
NFT1155 Subscription contract should allow batch operations #511
Closed
3 tasks
aaitor
aaitor approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@aaitor aaitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, probably update version to v3.5.3

@aaitor aaitor merged commit 0c7f877 into main Oct 5, 2023
3 checks passed
@aaitor aaitor deleted the feat/erc-1155-batch branch October 5, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaitor aaitor aaitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NFT1155 Subscription contract should allow batch operations
2 participants
@mrsmkl @aaitor