Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: non-subscription nfts have no duration field #140

Merged
merged 2 commits into from
Apr 20, 2023
Merged

fix: non-subscription nfts have no duration field #140

merged 2 commits into from
Apr 20, 2023

Conversation

r-marques
Copy link
Member

Description

  • Improved error responses from /nft-transfer

Is this PR related with an open issue?

Related to Issue #138

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

@r-marques
fix: non-subscription nfts have no duration field
75300ad 
- Improved error responses from /nft-transfer
@r-marques r-marques requested review from a team as code owners April 20, 2023 07:26
aaitor
aaitor approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@aaitor aaitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@r-marques r-marques merged commit 3778765 into main Apr 20, 2023
2 checks passed
@r-marques r-marques deleted the fix/duration-non-subscription branch April 20, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaitor aaitor aaitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-marques @aaitor