Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service refactor #21

Merged
merged 25 commits into from
Sep 22, 2022
Merged

Service refactor #21

merged 25 commits into from
Sep 22, 2022

Conversation

mrsmkl
Copy link
Contributor

@mrsmkl mrsmkl commented Sep 20, 2022 •
edited

Description

Add a description of your changes here.

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

@mrsmkl mrsmkl requested review from a team as code owners September 20, 2022 09:08
r-marques
r-marques reviewed Sep 20, 2022
View reviewed changes
src/auth/auth.service.ts Outdated Show resolved Hide resolved
r-marques
r-marques reviewed Sep 20, 2022
View reviewed changes
src/auth/auth.service.ts Outdated Show resolved Hide resolved
@r-marques
Copy link
Member

there is both a package-lock.json and yarn.lock in this repo

aaitor
aaitor reviewed Sep 22, 2022
View reviewed changes
src/common/helpers/agreement.ts
if (!url) {
throw new InternalServerErrorException(undefined, 'Bad URL')
// TODO: add log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep these comments, adding better logging should be the next thing to do.

src/auth/auth.service.ts Outdated Show resolved Hide resolved
src/access/access.controller.ts Outdated Show resolved Hide resolved
@mrsmkl mrsmkl merged commit 6bdc117 into main Sep 22, 2022
@mrsmkl mrsmkl deleted the feat/service-refactor branch September 22, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-marques r-marques r-marques left review comments

@aaitor aaitor aaitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrsmkl @r-marques @aaitor