Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation and yarn #22

Merged
merged 11 commits into from
Sep 27, 2022
Merged

Documentation and yarn #22

merged 11 commits into from
Sep 27, 2022

Conversation

aaitor
Copy link
Member

@aaitor aaitor commented Sep 26, 2022

Description

Add a description of your changes here.

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

@aaitor aaitor requested review from a team as code owners September 26, 2022 16:26
@aaitor aaitor mentioned this pull request Sep 26, 2022
12 tasks
Copy link
Contributor

@mrsmkl mrsmkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, let's update the sdk-js and sdk-dtp packages here too

src/main.ts Outdated
@@ -28,7 +28,7 @@ const createIndexes = (app: NestExpressApplication) => {
}
)
);
Logger.log('Marketplace API is connected to ElasticSearch');
Logger.log('Nevermined Gateway is up and running');
clearInterval(tryConnectionInterval);
} catch {
Logger.log('Error to connect to ElasticSearch. Trying in 10s');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the gateway need to connect to elasticsearch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't. The removal of Elastic Search needs to be accomplished as part of a different PR because it's everywhere

@aaitor aaitor merged commit 577c66c into main Sep 27, 2022
@aaitor aaitor deleted the fix/documentation_yarn branch September 27, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants