Skip to content
This repository has been archived by the owner on Feb 8, 2022. It is now read-only.

Data owners should be able to download their own data without going #19

Merged
merged 5 commits into from
Sep 15, 2020

Conversation

aaitor
Copy link
Member

@aaitor aaitor commented Sep 14, 2020

Description

Data owners should be able to download their own data without going thru the order process.

The gateway supports this functionality thru the /download endpoint.
This change implements that feature.

Is this PR related with an open issue?

https://github.com/keyko-io/nevermined-internal/issues/76

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

…hru the order process.

The gateway supports this functionality thru the /download endpoint.
This change implements that feature.
@aaitor aaitor requested a review from a team as a code owner September 14, 2020 17:21
@@ -550,6 +553,84 @@ else if (service.type.equals(Service.ServiceTypes.COMPUTE.toString()))
}


/**
* Purchases an Asset represented by a DID. It implies to initialize a Service Agreement between publisher and consumer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this description is wrong. There is no need to purchase or to initialize a service agreement, right?

Copy link
Member

@r-marques r-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaitor aaitor merged commit 28b9db6 into master Sep 15, 2020
@aaitor aaitor deleted the feature/owner_download branch September 15, 2020 07:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants