Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use http query parameters in filename #24

Merged
merged 2 commits into from Sep 22, 2020
Merged

Conversation

r-marques
Copy link
Member

@r-marques r-marques commented Sep 21, 2020

Description

  • Updated gateway download method to skip the http query parameters when downloading a file. This is useful for cases where the url can be very long e.g.:
http://172.17.0.1:8060/pod-publishing-0641a636-be48-43dc-b46e-381e7b0c90cb/perf.txt?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIOSFODNN7EXAMPLE%2F20200921%2Feu-central-1%2Fs3%2Faws4_request&X-Amz-Date=20200921T190631Z&X-Amz-Expires=604800&X-Amz-SignedHeaders=host&X-Amz-Signature=b8011dbd89ebeecf32450475f8f1b0a5fa4488c2e512a77384999201ccfbfc38
  • Added tests
  • bumped version

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

@r-marques r-marques requested a review from a team as a code owner September 21, 2020 19:47
@aaitor aaitor merged commit 72533d9 into master Sep 22, 2020
@r-marques r-marques deleted the fix/filename-download branch November 6, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants