Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use commons convert method #30

Merged
merged 1 commit into from Dec 4, 2020
Merged

Use commons convert method #30

merged 1 commit into from Dec 4, 2020

Conversation

eruizgar91
Copy link
Member

Description

Use convert to bytes method from the commons utils library.

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

@eruizgar91 eruizgar91 requested review from a team as code owners December 4, 2020 13:49
r-marques
r-marques approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@r-marques r-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eruizgar91 eruizgar91 merged commit d72e98c into master Dec 4, 2020
@eruizgar91 eruizgar91 deleted the feature/use-commons-method branch December 4, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaitor aaitor aaitor approved these changes

@r-marques r-marques r-marques approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eruizgar91 @aaitor @r-marques