Add ExampleLength cop #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| cop_config['Max'] | ||
| end | ||
|
|
||
| def code_length(node) |
There was a problem hiding this comment.
|
TODO:
|
andyw8
force-pushed
the
add-long-example-cop
branch
5 times, most recently
from
2c269f2
to
ddc813c
Compare
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ## master (unreleased) | |||
|
|
|||
| * Add `RSpec::LongExample` cop. ([@andyw8][]) | |||
andyw8
force-pushed
the
add-long-example-cop
branch
from
ddc813c
to
86b82f9
Compare
|
@nijikon updated based on your suggestions. |
|
@andyw8 please rebase on top of master |
This was suggested by @agrimm in issue rubocop#40 A long example is a form of the Obscure Test smell: http://xunitpatterns.com/Obscure%20Test.html I've chosen a default maximum of 5 lines on the basis that a typical example would contain 3 lines of setup, one line of execution and one line of assertion. However, this is quite dependent on the style used in the codebase. Suites which rely more on `let` and `before` blocks would likely have shorter example blocks. Somewhat ironically, I had to set the configuration for rubocop-rspec itself to quite a high value (12 lines).
andyw8
force-pushed
the
add-long-example-cop
branch
from
86b82f9
to
94fb85c
Compare
|
@nijikon done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was suggested by @agrimm in issue #40
A long example is a form of the Obscure Test smell:
http://xunitpatterns.com/Obscure%20Test.html
I've chosen a default maximum of 5 lines on the basis that a typical
example would contain 3 lines of setup, one line of execution and one
line of assertion. However, this is quite dependent on the style used in
the codebase. Suites which rely more on
letandbeforeblocks wouldlikely have shorter example blocks.
Somewhat ironically, I had to set the configuration for rubocop-rspec
itself to quite a high value (12 lines).