Add Mike's photo and bio, etc. #6
Conversation
- Add Mike's headshot - Add Mike's bio and headshot to the about page.
- Change all indents to tab chars, for consistency. - Previous commit had both tab indents and 2-space indents. - This and other pages strongly prefer tab indents (not entirely consistent though). FTR, I like space char indents myself. In either case, it might be a good idea to do a site-wide style refactor.
|
Mike is our Creative Director. Did he give you the bio or did you write it? We use soft tabs. 2 spaces. So that should be changed back. |
|
I grabbed the bio from a BN marketing document. I added the first sentence. |
Ok. (I also opened #8 to do this for the whole site). |
| <h1>“The Guys”</h1> | ||
| <section id="logan"> | ||
| <h2>Logan Leger</h2> | ||
| <%= image_tag("logan_headshot.png", :width => "125px") %> |
There was a problem hiding this comment.
You can use the new hash syntax in Ruby 1.9:
image_tag("logan_headshot.png", width: "125px")
|
Change Mike's bio to the following:
Also, @jmhooper graduated, so let's update his bio. Change:
to:
And change:
to:
Make those changes and then I think this is good to go. |
|
Done. |
Add Mike's photo and bio, etc.
|
Accidentally an extra |
|
Usually, before we merge, we do a squash, so that we clean up the git history a little. When you do some fix up commits, like you have here, it just adds noise, so we streamline those into one commit so it makes more sense. But it looks good! I just deployed it so you can see it live. Good job. 🎉 |
Add Mike's photo and bio, and other changes to the about page.
Also changed Jonathan's headshot at his request. Also made the indent style consistent throughout the page (I assumed that tab chars are preferred).
Closes #4. And hopefully gets #5 right.