Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prototype.js breaks timemap #21

Closed
GoogleCodeExporter opened this issue Mar 28, 2016 · 1 comment
Closed

prototype.js breaks timemap #21

GoogleCodeExporter opened this issue Mar 28, 2016 · 1 comment

Comments

@GoogleCodeExporter
Copy link

Reproduction:
1. Include prototype.js (from http://prototypejs.org) in any page using
TimeMap.
2. Fire it up.

Output:
Error: iterator.bind is not a function, in prototype.js

The problem is line 212 in timemap.js.  It uses the for (x in
some_iterable) method of iterating over functions in filters.chain. 
Unfortunately, since prototype works by extending base objects like, say,
Object itself), there are some extra keyed items in the array Object, like
the each method, so in addition to calling the filter methods added by
TimeMap, prototypes each function also gets called and bonks.

I've attached a very simple patch that seems to fix the problem.

Original issue reported on code.google.com by kenichi....@gmail.com on 11 Jul 2008 at 3:29

Attachments:

@GoogleCodeExporter
Copy link
Author

Fixed in trunk.

Original comment by nick.rab...@gmail.com on 18 Aug 2008 at 4:16

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant