Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] stepsNavigation allows you jump past steps that need validation #153

Open
newbreedofgeek opened this issue Sep 19, 2019 · 1 comment · May be fixed by #157
Open

[BUG] stepsNavigation allows you jump past steps that need validation #153

newbreedofgeek opened this issue Sep 19, 2019 · 1 comment · May be fixed by #157
Assignees
Labels

Comments

@newbreedofgeek
Copy link
Owner

Describe the bug
There has been some regression after last few PRs, you can now directly jump past steps that need validation (when you use the top navigation links via stepsNavigation)

To Reproduce
Steps to reproduce the behavior:

  1. Run the Dev server or go to live demo https://newbreedofgeek.github.io/react-stepzilla/
  2. Click on 'step 6'
  3. It goes directly to Step 6, even though Step 3 had a validation condition

Expected behavior
When we clicked on 'step 6' it should do nothing as it detects a middle step needs validation. The behaviour should be the same as follows.

  1. Run the Dev server or go to live demo https://newbreedofgeek.github.io/react-stepzilla/
  2. Click on 'step 6'
  3. It goes directly to Step 6, even though Step 3 had a validation condition
  4. now click on 'step 3'
  5. now click on 'step 4' - notice the validation is shows
  6. now click on 'step 1', now try to jump to 'step 6' again. Notice that it now prevents you and does nothing. Seems this direct jump logic is trigger only after we did 5. above

Screenshots
none

Desktop (please complete the following information if applicable):
all

Smartphone (please complete the following information if applicable):
n/a

Additional context
Add any other context about the problem here.

@zeel zeel self-assigned this Oct 7, 2019
zeel pushed a commit that referenced this issue Oct 7, 2019
@zeel
Copy link
Collaborator

zeel commented Oct 7, 2019

fixed this issue by using correct logic.

@zeel zeel linked a pull request Jan 8, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants