-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Critical error on Subgraph creation #345
Comments
This is a pretty big issue - both in terms of severity, as well as complexity unfortunately. In essence, the changes introduced by #328 added a conflicting system for how to handle inputs/outputs for graphs. Previously, I had separate Ideally, I would just let the subgraph input nodes emit the outside value as their output value but I had a few issues when implementing it. In addition, I'd like to consolidate the |
To reproduce just create subgraph.
Looks like regression after 15a45c4
But probably the core reason is an attempt to recalculate subgraph while it's being destroyed https://github.com/newcat/baklavajs/blob/master/packages/core/src/graphNode.ts#L130 :
The text was updated successfully, but these errors were encountered: