Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix high dpi node motion issues #113

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Fix high dpi node motion issues #113

merged 1 commit into from
Dec 23, 2020

Conversation

QcFe
Copy link
Contributor

@QcFe QcFe commented Dec 16, 2020

Hey, thanks for developing this amazing project!
I normally use a high density display and noticed the mouse behaved weirdly, I think it's what described in #20.
This should fix, hopefully

@newcat
Copy link
Owner

newcat commented Dec 23, 2020

Thanks for the PR and sorry for replying late. I just checked and this change indeed solves the issue in Chrome. But we then get the wrong behaviour in Firefox 😄 I am going to merge it anyway, since Chrome has a higher market share, so more people benefit from Baklava running properly in Chrome than in Firefox. Since I do want to avoid browser detection, I will try to find out, which browser is not spec-compliant and open an issue in the respective bugtracker as soon as I have enough information.

@newcat newcat merged commit 3b9bcbe into newcat:master Dec 23, 2020
@QcFe
Copy link
Contributor Author

QcFe commented Dec 24, 2020

No problem!
Heh, my super bad, I forgot to chech if everything was working on Firefox. I trusted a bit too much what I found on the w3c and caniuse...
At least, indeed, this way the bug will be encountered by a smaller user base. I'll try to find more information about this when I get time.
Thank you for merging my PR btw!

@code-is-art
Copy link

This doesn't work for me and I have to revert it to work on both Chrome and Firefox on OSX . Maybe this should be an optional setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants