Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed node title cursor #124

Merged
merged 1 commit into from
Mar 7, 2021
Merged

Changed node title cursor #124

merged 1 commit into from
Mar 7, 2021

Conversation

LukasLoeffler
Copy link
Contributor

@LukasLoeffler LukasLoeffler commented Feb 24, 2021

Hello,

in my opinion the current cursor for the title of the node is not the best option. In my opinion the grab and the grabbing cursor are more suitable. The move cursor is indeed used to move elements (see MDN cursor)
But this source also says that grab/grabbing "Indicates that something can be grabbed (dragged to be moved)."
The move cursor is fine by itself but I think the combination out of grab and grabbing is better because if you start dragging you will see the change between draggable and dragging better.

Let me know if you are the same opinion or if I am missing something.

Example:
KVnHxQGuRe

If node is dragged cursor is grabbing
If node is not dragged cursor is grab
@newcat
Copy link
Owner

newcat commented Mar 7, 2021

Very nice! I like that there is also some indication that the node can be dragged when just hovering above the title element - currently there is no indication at all. Thanks for the PR!

@newcat newcat merged commit d1f1f8c into newcat:master Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants