Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kitchen-terraform version in tutorials to 6.1 #477

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

sshcherbakov
Copy link
Contributor

The version 5.7 used in Getting Started tutorials to date doesn't work with the recent Terraform versions. Changing 5.7 to 6.1 fixes the issues.

@sshcherbakov
Copy link
Contributor Author

Fixes #476

Copy link
Collaborator

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, @sshcherbakov! I only have one request below 👇🏼

@sshcherbakov
Copy link
Contributor Author

I removed the highlighted change and run the referenced bundle exec middleman build --build-dir docs command. It modified icons in the docs/ folder. Updated the PR with those changes.

Copy link
Collaborator

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates!

@aaron-lane aaron-lane merged commit be1ee6c into newcontext-oss:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants