Fix/greedy style inclusion #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The built styles are pulling in base tailwind styles which are targeting basic elements like
button. This was making all buttons that didn't have a defined background color transparent and effectively disappearing. We noticed it on the wonder blocks button.This PR removes the base tailwind styles from the built files. Tested and the pre-publish when coming soon is active modal still displays fine without these base styles.
Ideally, we can follow up and use some existing or core classes for styling so this modal doesn't need its own stylesheet. I bet it could be done fairly simply, but in order to get this out quickly here's a quick fix.