Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Drawer Highlighting/Redirection bugs #123

Merged
merged 3 commits into from
Dec 12, 2022
Merged

Fix Drawer Highlighting/Redirection bugs #123

merged 3 commits into from
Dec 12, 2022

Conversation

arunshenoy99
Copy link
Member

Fixes:

  1. Primary Nav Link not reflecting the correct active top step.
  2. Primary Nav link resetting back to the first sub step instead of the currently active one.
  3. Inner Nav menus also highlight the correct higher level step.

@arunshenoy99 arunshenoy99 changed the title Fix drawer bugs Fix Drawer Highlighting/Redirection bugs Dec 9, 2022
@officiallygod
Copy link
Member

Can we also do the same logic for Get Started pages too? In-case someday we decide to let the user use the drawer for navigation?

abhijitb
abhijitb approved these changes Dec 11, 2022
View reviewed changes
Copy link
Contributor

@abhijitb abhijitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ... we just need the text for the drawer

themes-style-drawer

@arunshenoy99
Copy link
Member Author

Looks good ... we just need the text for the drawer

themes-style-drawer

#120 takes care of this.

@Yashita101 Yashita101 self-requested a review December 12, 2022 07:06
@arunshenoy99 arunshenoy99 merged commit d0d5e2f into release/v1.0.0 Dec 12, 2022
@arunshenoy99 arunshenoy99 deleted the PRESS2-387-fix-drawer-bugs branch December 12, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhijitb abhijitb abhijitb approved these changes

@officiallygod officiallygod officiallygod approved these changes

@Yashita101 Yashita101 Yashita101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arunshenoy99 @officiallygod @abhijitb @Yashita101