Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install Plugins Extended #517

Merged
merged 8 commits into from
Mar 18, 2024
Merged

Install Plugins Extended #517

merged 8 commits into from
Mar 18, 2024

Conversation

officiallygod
Copy link
Member

@officiallygod officiallygod commented Mar 11, 2024 •
edited
Loading

Proposed changes

Based on the Hiive Flags, a particular subset of plugins will be installed and activated.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@officiallygod officiallygod added the WIP PR is a Work in Progress and not ready for review. label Mar 11, 2024
@officiallygod officiallygod self-assigned this Mar 11, 2024
@officiallygod officiallygod added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels Mar 11, 2024
arunshenoy99
arunshenoy99 requested changes Mar 12, 2024
View reviewed changes
includes/Services/PluginService.php Outdated Show resolved Hide resolved
includes/Services/PluginService.php Outdated Show resolved Hide resolved
includes/Services/PluginService.php Outdated Show resolved Hide resolved
@arunshenoy99 arunshenoy99 added QA This PR is in QA and removed Code Review The PR is in Code Review labels Mar 15, 2024
@officiallygod officiallygod added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Mar 18, 2024
@arunshenoy99 arunshenoy99 merged commit 5280078 into trunk Mar 18, 2024
4 of 5 checks passed
@arunshenoy99 arunshenoy99 deleted the feature/install-plugins-extended branch March 18, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

Assignees

@officiallygod officiallygod

Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@officiallygod @arunshenoy99