Cypress tests for Events in site-features page #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avneet-raj
reviewed
Mar 18, 2024
| it( 'Check to make sure Sidebar opens', () => { | ||
| BasicSidebarCheck(); | ||
| } ); | ||
| }; | ||
| } |
There was a problem hiding this comment.
Why have we removed ';' at the end?
There was a problem hiding this comment.
Its due to linting. I used command provided earlier.
npx wp-scripts lint-js <file-path> --no-ignore --fix
avneet-raj
reviewed
Mar 18, 2024
| @@ -18,7 +18,11 @@ export const APIList = { | |||
| basic_info: | |||
| '/index.php?rest_route=%2Fnewfold-onboarding%2Fv1%2Fevents%2Fbatch&flow=wp-setup&_locale=user', | |||
| basic_info_ecomm: | |||
| '/index.php?rest_route=%2Fnewfold-onboarding%2Fv1%2Fevents%2Fbatch&flow=ecommerce&_locale=user' | |||
| '/index.php?rest_route=%2Fnewfold-onboarding%2Fv1%2Fevents%2Fbatch&flow=ecommerce&_locale=user', | |||
There was a problem hiding this comment.
we are using the same API for general and ecomm flow, so I think it's better to have only 2 APIs, one for general and one for ecomm.
also, please update where the APIs have been used.
avneet-raj
approved these changes
Mar 18, 2024
avneet-raj
added
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GA events test scripts for site-features step from both general onboarding and ecommerce onboarding
