Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SiteGen Welcome Step #578

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Remove SiteGen Welcome Step #578

merged 5 commits into from
Jun 14, 2024

Conversation

officiallygod
Copy link
Member

@officiallygod officiallygod commented Jun 13, 2024 •
edited
Loading

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@officiallygod officiallygod added the WIP PR is a Work in Progress and not ready for review. label Jun 13, 2024
@officiallygod officiallygod self-assigned this Jun 13, 2024
ajayadav09
ajayadav09 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@ajayadav09 ajayadav09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the site gen flow on local. Looks good.

@officiallygod officiallygod added QA This PR is in QA and removed WIP PR is a Work in Progress and not ready for review. labels Jun 13, 2024
@officiallygod officiallygod added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Jun 14, 2024
@officiallygod officiallygod merged commit 2e5d8f0 into trunk Jun 14, 2024
5 of 9 checks passed
@officiallygod officiallygod deleted the enhance/remove-welcome-step branch June 14, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajayadav09 ajayadav09 ajayadav09 approved these changes

Assignees

@officiallygod officiallygod

Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@officiallygod @ajayadav09