Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecommerce version bump to 1.3.6 #299

Conversation

ramyakrishnai
Copy link
Contributor

Changes included in this version of Ecommerce are as follows
PRESS4-365 | Update Dashboard Hero by @sumathi3399 in newfold-labs/wp-module-ecommerce#159
Replaced toplevel_page_bluehost hook and added generic hook to call the method experience level from wp-module-onboarding-data to make it compatible with all brands by @ramyakrishnai in newfold-labs/wp-module-ecommerce#158

@circlecube
Copy link
Member

I copied these updates over to another PR so the tests would run but I'm seeing a couple of failures. Can you look into it?

I'm a bit concerned about using an iframe like this as a preview. Have we tested the performance implications of loading the front end of the website here within the plugin app on the backend?

If we're set on an iframe, we should do something so the iframe contents are not selectable by the user. In my tests, I was able to navigate the preview and click links and even search my site. Maybe a transparent pseudo-element with a z-index above the iframe? I would suggest a CSS rule to address this, but I don't think using user-select: none would work for the iframe content.

One cypress test is now failing on the plugin app home screen due to the iframe not passing the accessibility check. We need to add a title attribute to the iframe so that accessibility tests will pass.

I'd also recommend we remove the admin bar from the iframe preview here.

It looks like the other failing test is due to the button text change, so that should be simple enough to update. That's a test in the coming soon module, so I can update it there once these other issues are fixed. I do think in the future we'll want to rework the coming soon functionality so it is all contained in that module (there are already tickets for that on our end too).

@ramyakrishnai
Copy link
Contributor Author

hi @circlecube

We have acomodated the changes requested in the above comment. Sharing the PR link for your reference.
newfold-labs/wp-module-ecommerce#161

Can you please let us know if we can use an alternative to iframe to show the site preview.

Thank you!

@circlecube
Copy link
Member

Thanks for the updates @ramyakrishnai - this update has been copied and merged into the release branch, so I'll close this PR now.

@circlecube circlecube closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants