Feature/workflow updates #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@circlecube Looks like you have some conflicts. Also, should be merging into |
wpscholar
approved these changes
Oct 3, 2022
| - name: Run NPM Install | ||
| run: npm install | ||
| - name: NPM Install | ||
| run: npm install --legacy-peer-deps |
There was a problem hiding this comment.
We may not have to have the --legacy-peer-deps flag. If you can run a normal npm install without getting any errors/warnings, we don't need it. If you get a notice about missing peer dependencies, then we either need to add those or add this flag. It was easier to add the flag on the Bluehost plugin, but may not be required on the other plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update workflows
Addresses #10