Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbols not found inside godep GOPATH #1

Open
liggitt opened this issue Mar 17, 2016 · 2 comments
Open

Symbols not found inside godep GOPATH #1

liggitt opened this issue Mar 17, 2016 · 2 comments

Comments

@liggitt
Copy link

liggitt commented Mar 17, 2016

(Moved from microsoft/vscode-go#250, I didn't realize the symbol lookup was a separate project)

I have a project using godeps to nest vendored packages.

The project root is at /Users/myuser/go/src/github.com/myuser/myrepo

The "go.gopath" setting is set to "/Users/myuser/go/src/github.com/myuser/myrepo/Godeps/_workspace:/Users/myuser/go"

Most things work (definition finding, etc), but "Show all symbols" does not include things inside the nested Godeps path (which is Godeps/_workspace relative to the project folder)

@ironcladlou
Copy link

(Moved from microsoft/vscode-go#250 (comment))

Check this branch of my fork of the go-symbols tool which use the build context for lookups.

I have an idea of how to make my branch backwards compatible with current go-symbols' behavior by creating a build.FakeContext, but it's low priority for me right now since the current behavior is pretty much broken for every Go project I work with due to vendor usage.

I think this tool would also benefit from some sort of caching.

We might want to take this discussion to the go-symbols project. cc @newhook

@ironcladlou
Copy link

@newhook, any thoughts here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants