Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust required fields #301

Merged
merged 5 commits into from Sep 21, 2020
Merged

Conversation

dhcole
Copy link
Member

@dhcole dhcole commented Sep 18, 2020

This disables the required status on fields on the education and employment sections of the assessment flow. This is done by 1) setting the optional property in the static API for Assessment Entities, and 2) adjusting the validation functions to respect the optional property.

Copy link
Contributor

@rossdakin rossdakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it, but looks good. Thanks for catching some of those existing bugs too.

@dhcole dhcole merged commit deb6679 into newjersey:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants