Skip to content

Commit

Permalink
chore: update references to DevEn change to Docs Engineering
Browse files Browse the repository at this point in the history
  • Loading branch information
josephgregoryii committed Mar 18, 2022
1 parent 35cce72 commit a68c1c3
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/check-translations-and-deserialize.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
base: develop
delete-branch: true
reviewers: jmiraNR
team-reviewers: developer-enablement
team-reviewers: docs-engineering

- name: Remove Completed Batches From Queue
if: steps.fetch-deserialize.outputs.successfulTranslations != 0 && steps.create-pr.outcome == 'success'
Expand Down Expand Up @@ -144,7 +144,7 @@ jobs:
base: develop
delete-branch: true
reviewers: jmiraNR
team-reviewers: developer-enablement
team-reviewers: docs-engineering

- name: Remove Completed Batches From Queue
if: steps.fetch-deserialize.outputs.successfulTranslations != 0 && steps.create-pr.outcome == 'success'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/update-whats-new-ids.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ jobs:
})
console.log("Result:", result)
# Push directly to the `develop` branch so we get the changes included in the release PR
# Push directly to the `develop` branch so we get the changes included in the release PR
- name: Push Commit
if: steps.commit-changes.outputs.commit == 'true'
uses: ad-m/github-push-action@v0.6.0
Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
},
restrictions: {
users: [],
teams: ['developer-enablement']
teams: ['docs-engineering']
},
enforce_admins: null,
required_pull_request_reviews: {
Expand Down
11 changes: 6 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- [Unit tests](#unit-tests)
- [Using multiple versions of Node](#using-multiple-versions-of-node)
- [Cloning vs forking](#cloning-vs-forking)
- [Forks - GitHub Workflows / Actions](#forks---github-workflows--actions)
- [Submitting a PR from a forked repo](#submitting-a-pr-from-a-forked-repo)
- [Submitting a PR from a cloned repo](#submitting-a-pr-from-a-cloned-repo)
- [Using the `develop` branch](#using-the-develop-branch)
Expand Down Expand Up @@ -79,15 +80,15 @@ which clearly explains the setup and configuration of NVM.

### Cloning vs forking

To be able to [clone](https://help.github.com/en/github/creating-cloning-and-archiving-repositories/cloning-a-repository) this repository and contribute you will need to be given write access to the repository. This is reserved for New Relic Doc Writers. Contact the Developer Enablement team (#help-deven-websites Slack channel) if you need write access.
To be able to [clone](https://help.github.com/en/github/creating-cloning-and-archiving-repositories/cloning-a-repository) this repository and contribute you will need to be given write access to the repository. This is reserved for New Relic Doc Writers. Contact the Docs Engineering team (#help-deven-websites Slack channel) if you need write access.

To contribute without write access, you can [fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) the repository and contribute as needed. If you're planning to leave a fork open for a long time (for example, you're working on a complex set of changes to many docs), [sync your fork](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork) occasionally to avoid merge conflicts.

#### Forks - GitHub Workflows / Actions

This repository contains workflows that are not meant to be run on forks. If they do run, they will fail and generate alerts on every failed run.
This repository contains workflows that are not meant to be run on forks. If they do run, they will fail and generate alerts on every failed run.

By default, a user should see a prompt like this after cloning the repo when looking at the actions tab:
By default, a user should see a prompt like this after cloning the repo when looking at the actions tab:

![Disabled GitHub Actions](src/images/workflows_disabled_by_default.png 'disabled-workflows-prompt')

Expand Down Expand Up @@ -173,8 +174,8 @@ As a reminder, here's the format for a single-line commit, but you are welcome t
<type>(optional scope): <description>
```

When choosing a type, you can pick from any of the standard types (feat, fix, style, test, or chore) or you can add your own.
**Note**: There is a `documentation` type, but please refrain from using it for general documentation changes since it is intended for changes to the repository's documentation (such as `README.md` and `CONTRIBUTING.md`)
When choosing a type, you can pick from any of the standard types (feat, fix, style, test, or chore) or you can add your own.
**Note**: There is a `documentation` type, but please refrain from using it for general documentation changes since it is intended for changes to the repository's documentation (such as `README.md` and `CONTRIBUTING.md`)

As far as scope, we recommend that you include this because it helps us identify relevant commits. For the docs project, the scope might refer to the part of the docs you are editing (for example, APM or errors inbox). If you are suggesting a code change to the docs site, insert the section of the codebase you worked on.

Expand Down

0 comments on commit a68c1c3

Please sign in to comment.