Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Notes JSON endpoint returns description #1370

Closed
cade-conklin opened this issue Mar 17, 2021 · 12 comments
Closed

Release Notes JSON endpoint returns description #1370

cade-conklin opened this issue Mar 17, 2021 · 12 comments
Labels
eng issues related to site functionality that requires engineering enhancement New feature or request

Comments

@cade-conklin
Copy link
Contributor

Is your feature request related to a problem? Please describe

The current JSON endpoint (https://docs.newrelic.com/api/agent-release-notes.json) returns a JSON with each agent, version, and attached release date. The Release Notes Parser, a service that checks each release note to see if any changes to agent supportability, is still broken because it relies on the description of each release note to work. This is because it uses Regexes to detect the aforementioned changes in supportability.

Describe the solution you'd like

I would like to have the release notes description returned for each release note in the JSON https://docs.newrelic.com/api/agent-release-notes.json. Upon further research, the descriptions lie within the MD files in src/content/docs/release-notes/agent-release-notes in this repo. Being able to return those with the rest of the information would give the Release Notes Parser the necessary context to do its job.

Describe why this important to you

While this service scrapes the Release Notes to detect changes in supportability, its main purpose is to automatically detect changes we haven't accounted for in the Diagnostics CLI (a much larger service). This is a big problem because it is hard for Software Engineers to keep up with changes in release notes, and because of that it often leads to giving our customers false-positives (a version we detect running in their system may have been EOL'd by our agent but we would still give them a confirmation that they are good to go). In order to negate this problem, the description should be added to the JSON endpoint.

Additional context

I am not well-versed in JS or GraphQL, but I did some digging around the repo with a suggestion from Clinton Langosch. If there is any way that I could help any of you implement this, I would be more than open to pairing!

@cade-conklin cade-conklin added eng issues related to site functionality that requires engineering enhancement New feature or request labels Mar 17, 2021
@nr-opensource-bot nr-opensource-bot added this to Needs Triage in Docs PRs and Issues Mar 17, 2021
@jpvajda jpvajda removed this from Needs Triage in Docs PRs and Issues Mar 17, 2021
@jpvajda
Copy link

jpvajda commented Mar 17, 2021

the release notes json was added to support a specific service’s needs that didn't requiredescription. it just required version numbers and release dates. But we can considering at that data to the JSON payload, I'll see if we can get you some pointers on how to do this @cade-conklin and perhaps you can contribute this change to the project?

@cade-conklin
Copy link
Contributor Author

@jpvajda I just got back in for this week and I would love to see how I could contribute to this change!

@jpvajda
Copy link

jpvajda commented Mar 22, 2021

Thanks @cade-conklin The team is pretty heads down in this current sprint we are in, so I'll have to see if someone can give you some pointers next week, we'd love to assist you getting this feature into the site in the near future. cc @roadlittledawn

@cade-conklin
Copy link
Contributor Author

Awesome! We can connect about a time for next week

@jpvajda
Copy link

jpvajda commented Mar 24, 2021

@cade-conklin was interested in making this change but would need some pairing time with one of us to implement, we can consider this work for Sprint 1 if we have the bandwidth. I'll add to the list of tickets we may work on next to get a sense of how much time we need to spend paring on it.

@jpvajda jpvajda added this to the [DevEn] Sprint 1 milestone Mar 24, 2021
@jpvajda jpvajda moved this from Tentative next to To do in Developer Enablement Team Mar 30, 2021
@MoonlightKomorebi MoonlightKomorebi moved this from To do to In progress in Developer Enablement Team Mar 31, 2021
@MoonlightKomorebi MoonlightKomorebi self-assigned this Mar 31, 2021
@MoonlightKomorebi MoonlightKomorebi moved this from In progress to To do in Developer Enablement Team Mar 31, 2021
@MoonlightKomorebi MoonlightKomorebi removed their assignment Mar 31, 2021
@zstix zstix removed this from the [DevEn] Sprint 1 milestone Apr 7, 2021
@zstix zstix removed this from To do in Developer Enablement Team Apr 7, 2021
@jpvajda
Copy link

jpvajda commented Apr 7, 2021

@cade-conklin when you are ready to submit a PR for this change we'd be happy to review it. If you are intending to start work on this and need some guidance feel free to post a message in our help channel: #help-deven-websites

@stale
Copy link

stale bot commented May 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be automatically closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 8, 2021
@stale
Copy link

stale bot commented Jun 12, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be automatically closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 12, 2021
@jpvajda jpvajda removed the stale label Jun 14, 2021
@stale
Copy link

stale bot commented Jul 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be automatically closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 14, 2021
@jpvajda jpvajda removed the stale label Jul 14, 2021
@jpvajda jpvajda moved this from To do to Tentative next in Developer Enablement Team Jul 30, 2021
@jpvajda jpvajda removed this from Tentative next in Developer Enablement Team Aug 6, 2021
@stale
Copy link

stale bot commented Aug 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be automatically closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Sep 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be automatically closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 19, 2021
@jpvajda jpvajda removed the stale label Sep 20, 2021
@roadlittledawn
Copy link
Collaborator

i believe this was deployed couple months ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng issues related to site functionality that requires engineering enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants