Release Notes JSON Description Field #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Gatsby Cloud Build Reportdocs-website-develop 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 40m |
x8a
added
content
|
Hey, @jpvajda! Could you have a look at this? Thanks! |
|
I'm going to see if @roadlittledawn can review as well. It looks good to me, but he did some work on this part of the site so wanted another set of 👀 on it. Thanks for the contribution @x8a and @cade-conklin |
zstix
approved these changes
Sep 13, 2021
austin-schaefer
added
from_internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give us some context
The current release notes JSON return a JSON with fields: agent, version, and release date. One of our services relies on this JSON but needs a description field so that it can parse the release notes to determine the supportability for various agents. The change was very minor and involved adding an excerpt field to the GraphQL call. The length of each excerpt was arbitrarily set at 5000 assuming most release notes won't exceed that length. When running locally, this is what the new JSON will look like
Here is a link to the issue that was opened a while ago. The reason this was just now completed was that our team just now raised visibility on it again.
Are you making a change to site code?
Yes. This is a very small change!
If you're changing site code (rather than the content of a doc), please follow
conventional commit standards
in your commit messages and pull request title.