Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What's new IDs are getting committed to develop instead of release branch #5927

Closed
2 tasks done
LizBaker opened this issue Feb 2, 2022 · 1 comment · Fixed by #5948
Closed
2 tasks done

What's new IDs are getting committed to develop instead of release branch #5927

LizBaker opened this issue Feb 2, 2022 · 1 comment · Fixed by #5948
Assignees
@LizBaker
Labels
eng issues related to site functionality that requires engineering enhancement New feature or request
Projects
Developer Enablement Team

Comments

@LizBaker
Copy link
Contributor

LizBaker commented Feb 2, 2022 •
edited

Our update-whats-new-ids action is hardcoded to commit to develop. Now that we use release branches, any new IDs aren't picked up by the release containing the new post, but by a subsequent release. We want to update that to keep new IDs and posts together

AC

  • update the action to checkout the branch being PRed to main (checking out develop could add a whats new id for a post that doesn't exist on the release branch)
  • commit new IDs to the branch being PRed to main
@LizBaker LizBaker added enhancement New feature or request eng issues related to site functionality that requires engineering labels Feb 2, 2022
@LizBaker LizBaker self-assigned this Feb 2, 2022
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Hi @LizBaker 👋
Thank you for filing an issue! We'll triage your issue and let you know if we have questions, and then route it to the appropriate team so we can get it solved.

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Feb 2, 2022
@LizBaker LizBaker removed this from Hero to triage in Docs PRs and Issues Feb 2, 2022
@LizBaker LizBaker added this to In progress in Developer Enablement Team Feb 2, 2022
@LizBaker LizBaker added the sp:2 label Feb 2, 2022
@LizBaker LizBaker mentioned this issue Feb 3, 2022
Merged
@LizBaker LizBaker moved this from In progress to In review in Developer Enablement Team Feb 3, 2022
Developer Enablement Team automation moved this from In review to Done Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LizBaker LizBaker

Labels
eng issues related to site functionality that requires engineering enhancement New feature or request
Projects
Developer Enablement Team
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use release branch for whats new ID commits newrelic/docs-website
1 participant
@LizBaker