Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use release branch for whats new ID commits #5948

Merged
merged 2 commits into from Feb 4, 2022

Conversation

LizBaker
Copy link
Contributor

@LizBaker LizBaker commented Feb 3, 2022

This updates the whats new ID generating workflow to commit new IDs to the branch PRing main instead of develop

closes #5927

@LizBaker LizBaker requested a review from a team as a code owner February 3, 2022 18:10
@LizBaker LizBaker requested review from roadlittledawn and aswanson-nr and removed request for a team February 3, 2022 18:10
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

Hi @LizBaker 👋
Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Feb 3, 2022
aswanson-nr
aswanson-nr previously approved these changes Feb 3, 2022
Copy link
Contributor

@aswanson-nr aswanson-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 3, 2022

Gatsby Cloud Build Report

docs-website-develop

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 20m

@roadlittledawn
Copy link
Collaborator

@LizBaker i think the release branches have branch protection on them don't they? so we would need that remove protection part still right?

Copy link
Collaborator

@roadlittledawn roadlittledawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Docs PRs and Issues
Hero to triage
Development

Successfully merging this pull request may close these issues.

What's new IDs are getting committed to develop instead of release branch
4 participants