Create doc banner #11464
Merged
Create doc banner #11464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LizBaker
requested review from
clarkmcadoo and
tabathadelane
and removed request for
a team
|
Hi @LizBaker 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes). |
✅ docs-website-develop deploy preview ready
|
clarkmcadoo
reviewed
Feb 9, 2023
src/templates/docPage.js
Outdated
| @@ -34,6 +37,8 @@ const splitTOCTitle = (title = '') => { | |||
| return [titleText.join(' '), slug]; | |||
| }; | |||
|
|
|||
| const bannerHeight = '78px'; | |||
There was a problem hiding this comment.
can we SCREAMING_SNAKE_CASE this?
sunnyzanchi
requested changes
Feb 10, 2023
sunnyzanchi
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dismiss-able banner to specific docs based on frontmatter. When dismissed a value is set in local storage unique to the doc title. You can test this out on
/docs/mlops/get-started/intro-mlops/and/docs/mlops/bring-your-own/mlops-byo/which have temporary bannersfyi if you are logged into production it shouldn't show up at all 👀
TODO