Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browser-app-settings-page.mdx #11503

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Conversation

ally-sassman
Copy link
Contributor

Updated instructions to match the UI. This just needs a Hero review.

@ally-sassman ally-sassman added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Feb 13, 2023
@ally-sassman ally-sassman self-assigned this Feb 13, 2023
@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Feb 13, 2023
@github-actions
Copy link

Hi @a-sassman 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot requested a review from x8a February 13, 2023 18:38
@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 13, 2023

✅ docs-website-develop deploy preview ready

@ally-sassman ally-sassman moved this from Hero to triage to Needs review in Docs PRs and Issues Feb 13, 2023
@ally-sassman ally-sassman moved this from Needs review to Hero to triage in Docs PRs and Issues Feb 13, 2023
@zuluecho9 zuluecho9 requested review from zuluecho9 and removed request for x8a February 13, 2023 21:30

If you don't have access to this, it may be due to permissions.
If you cannot access this page, it may because you don't have admin-level permissions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could actually just remove this. We have a lot of things like this that are gated by various capabilities (in this case, this is related to the 'application settings' capability here: https://docs.newrelic.com/docs/accounts/accounts-billing/new-relic-one-user-management/user-capabilities/#browser) but in practice I think it's fine to not document all these things, because a) customers will generally assume if they can't see something it's due to permissions, and b) NR customers have admins dedicated to deciding what their users get access to and for that they'd review the user mgmt docs and make those decisions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. It's also obvious in the UI, which says "You need admin-level permissions to view this." I'll remove it then. Thank you!

zuluecho9
zuluecho9 previously approved these changes Feb 13, 2023
@ally-sassman ally-sassman merged commit 24e3fdf into develop Feb 13, 2023
@ally-sassman ally-sassman deleted the update-browser-settings-page branch February 13, 2023 21:50
@ally-sassman ally-sassman moved this from Hero to triage to In progress in Docs PRs and Issues Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants