Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(errors inbox): fingerprinting changes #12380

Merged
merged 7 commits into from
Apr 3, 2023
Merged

fix(errors inbox): fingerprinting changes #12380

merged 7 commits into from
Apr 3, 2023

Conversation

homelessbirds
Copy link
Contributor

@homelessbirds homelessbirds commented Mar 30, 2023 •
edited

Ready for review!

Correct me if I am wrong @elucus but we only have four agents who have documented error fingerprinting with errors inbox:

  • Go
  • Node
  • Python
  • Ruby

Missing:

  • .Net
  • Java (pending on 4.13)
  • PHP

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Mar 30, 2023
@github-actions
Copy link

Hi @homelessbirds 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@homelessbirds homelessbirds moved this from Hero to triage to In progress in Docs PRs and Issues Mar 30, 2023
@gatsby-cloud
Copy link

gatsby-cloud bot commented Mar 30, 2023 •
edited

✅ docs-website-develop deploy preview ready

@homelessbirds homelessbirds self-assigned this Mar 30, 2023
@homelessbirds homelessbirds added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Mar 30, 2023
nbaenam
nbaenam previously approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@nbaenam nbaenam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

@nbaenam nbaenam moved this from In progress to Waiting on TW to merge in Docs PRs and Issues Mar 31, 2023
@elucus
Copy link
Contributor

elucus commented Mar 31, 2023

@fallwith I don't think we should have these changes here. Didn't we already update the docs?

@fallwith
Copy link
Contributor

@fallwith I don't think we should have these changes here. Didn't we already update the docs?

@elucus We're good here. The only Ruby agent docs specific changes being made here are to create and leverage HTML anchor tags to make it easier to link directly to either the user tracking or the error fingerprinting section. I like the addiitons.

@homelessbirds homelessbirds merged commit 58fb484 into develop Apr 3, 2023
7 checks passed
@homelessbirds homelessbirds deleted the sd-fingerprinting-3-29 branch April 3, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fallwith fallwith fallwith left review comments

@nbaenam nbaenam nbaenam left review comments

@meda123 meda123 Awaiting requested review from meda123

@elucus elucus Awaiting requested review from elucus

Assignees

@homelessbirds homelessbirds

Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Docs PRs and Issues
Waiting on TW to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@homelessbirds @elucus @fallwith @nbaenam