Bring back video homepage layout #12468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabathadelane
requested review from
sunnyzanchi and
LizBaker
and removed request for
a team
|
Hi @tabathadelane 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes). |
github-actions
bot
added
the
eng
✅ docs-website-develop deploy preview ready
|
sunnyzanchi
previously approved these changes
Apr 6, 2023
LizBaker
reviewed
Apr 6, 2023
| @@ -19,6 +19,7 @@ export const TOGGLE_VIEWS = { | |||
| const mobileBreakpoint = '450px'; | |||
|
|
|||
| const ToggleSelector = ({ className, showTooltip }) => { | |||
| showTooltip = true; | |||
There was a problem hiding this comment.
should this be here? this means it pops up even if you're already on the alternate view
There was a problem hiding this comment.
nope 🤡 It wasn't even doing what i wanted it to, and i forgot i put it there
LizBaker
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Questions:
forceLightModeandanimatedoptions on DocTile that we added for the Persona Homepage