Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted fixes: .NET config precedence fix, NRQL bucket fix #13359

Merged
merged 7 commits into from
Jun 6, 2023

Conversation

zuluecho9
Copy link
Contributor

@zuluecho9 zuluecho9 commented Jun 5, 2023

Fixes include:

fix(.net config): fixing some precedence wording about config
Adding context about why you'd use NRQL buckets

@zuluecho9 zuluecho9 added the content requests related to docs site content label Jun 5, 2023
@zuluecho9 zuluecho9 self-assigned this Jun 5, 2023
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Hi @zuluecho9 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Jun 5, 2023
@zuluecho9 zuluecho9 changed the title fix(.net config): fixing some precedence wording Assorted fixes Jun 5, 2023
@zuluecho9 zuluecho9 changed the title Assorted fixes Assorted fixes: .NET config precedence fix, NRQL bucket fix Jun 5, 2023
@zuluecho9 zuluecho9 added the from_tw Identifies issues/PRs from Tech Docs writers label Jun 5, 2023
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 5, 2023

✅ docs-website-develop deploy preview ready

@zuluecho9 zuluecho9 moved this from Hero to triage to In progress in Docs PRs and Issues Jun 5, 2023
jeff-colucci
jeff-colucci previously approved these changes Jun 5, 2023
Copy link
Contributor

@jeff-colucci jeff-colucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only saw small things so I'm approving, looks great overall!

@zuluecho9 zuluecho9 merged commit 0cdbf89 into develop Jun 6, 2023
8 checks passed
@zuluecho9 zuluecho9 deleted the ASsorted-fixes-June-5 branch June 6, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants