Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add language identifiers #14767

Merged
merged 2 commits into from
Oct 5, 2023
Merged

chore: add language identifiers #14767

merged 2 commits into from
Oct 5, 2023

Conversation

brnhensley
Copy link
Contributor

[output] in a shell block should format them as terminal output, I've seen this work in src/content/docs/browser/new-relic-browser/lab/set-up-env.mdx but haven't tested it out personally yet

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

  • What problems does this PR solve?
  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
  • If your issue relates to an existing GitHub issue, please link to it.

[output] in a shell block should format them as terminal output, I've seen this work in `src/content/docs/browser/new-relic-browser/lab/set-up-env.mdx` but haven't tested it out personally yet
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Hi @brnhensley 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Oct 3, 2023
@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 3, 2023

✅ docs-website-develop deploy preview ready

Copy link
Contributor

@rhetoric101 rhetoric101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brnhensley thanks for adding these formatting fences. Could you take a look at two comments below about the help usage?

@rhetoric101 rhetoric101 self-assigned this Oct 3, 2023
@rhetoric101 rhetoric101 added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Oct 3, 2023
@rhetoric101 rhetoric101 moved this from Hero to triage to In progress in Docs PRs and Issues Oct 3, 2023
@rhetoric101 rhetoric101 moved this from In progress to Hero to triage in Docs PRs and Issues Oct 4, 2023
@rhetoric101 rhetoric101 removed their assignment Oct 4, 2023
@ally-sassman ally-sassman moved this from Hero to triage to Waiting on SME/Blocked in Docs PRs and Issues Oct 4, 2023
@brnhensley
Copy link
Contributor Author

The new build if done, this is the formatting I was trying to achieve:
image

@rhetoric101 rhetoric101 self-assigned this Oct 5, 2023
Copy link
Contributor

@rhetoric101 rhetoric101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brnhensley thanks for explaining how the output work in the formatting. This looks good!

@rhetoric101 rhetoric101 merged commit 41d176b into newrelic:develop Oct 5, 2023
10 checks passed
@brnhensley brnhensley deleted the patch-3 branch October 6, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
Docs PRs and Issues
Waiting on SME/Blocked
Development

Successfully merging this pull request may close these issues.

None yet

2 participants