Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add release date to security RSS feed #15923

Merged
merged 2 commits into from
Jan 23, 2024
Merged

feat: add release date to security RSS feed #15923

merged 2 commits into from
Jan 23, 2024

Conversation

tabathadelane
Copy link
Contributor

@tabathadelane tabathadelane commented Jan 23, 2024 •
edited

✨ Summary

pubDate is now accurate and not the same as lastBuildDate

build preview security rss

The RSS feed validator did find some warnings, but they match up exactly to our current page:

🔮 Engineering checklist

  • Relevant documentation including README's or Confluence are updated to reflect these changes
  • Code changes are self-documenting or clearly commented/documented
  • New tests are added where applicable and total coverage remains >70%
  • No new warnings or errors where added to the browser or build console
  • All downstream dependencies for DaaS have been considered for negative impacts
    • security-bulletin rss feed

@tabathadelane tabathadelane added the eng issues related to site functionality that requires engineering label Jan 23, 2024
@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Jan 23, 2024
@github-actions GitHub Actions
Copy link

Hi @tabathadelane 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@gatsby-cloud Gatsby Cloud
Copy link

gatsby-cloud bot commented Jan 23, 2024 •
edited

✅ docs-website-develop deploy preview ready

@tabathadelane tabathadelane marked this pull request as ready for review January 23, 2024 20:13
@tabathadelane tabathadelane requested a review from a team as a code owner January 23, 2024 20:13
@tabathadelane tabathadelane requested review from sunnyzanchi and LizBaker and removed request for a team January 23, 2024 20:13
clarkmcadoo
clarkmcadoo previously approved these changes Jan 23, 2024
View reviewed changes
@clarkmcadoo
Copy link
Contributor

woo!

Screenshot 2024-01-23 at 2 32 03 PM

@tabathadelane tabathadelane merged commit 1ec0706 into develop Jan 23, 2024
14 checks passed
@tabathadelane tabathadelane deleted the tabatha/rss-feed-dates branch January 23, 2024 22:04
@homelessbirds homelessbirds removed this from Hero to triage in Docs PRs and Issues Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunnyzanchi sunnyzanchi sunnyzanchi approved these changes

@clarkmcadoo clarkmcadoo clarkmcadoo approved these changes

@LizBaker LizBaker Awaiting requested review from LizBaker LizBaker is a code owner automatically assigned from newrelic/docs-engineering

Assignees
No one assigned
Labels
eng issues related to site functionality that requires engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tabathadelane @clarkmcadoo @sunnyzanchi