Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update kafka docs and related ones #16556

Merged
merged 1 commit into from
May 8, 2024

Conversation

paologallinaharbur
Copy link
Member

This PR:

  • fixes the link for the latest kafka installer pointing to the exe one
  • clarify the jmx page
  • removed in different places the requirement to restart the agent

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 720fcd0
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/65f802288e808e000893dfd5
😎 Deploy Preview https://deploy-preview-16556--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi @paologallinaharbur 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Mar 18, 2024
Copy link

github-actions bot commented Mar 18, 2024

Netlify Preview Deployment Information

This comment will auto update when your preview build is ready

1 similar comment
Copy link

Netlify Preview Deployment Information

This comment will auto update when your preview build is ready

@@ -112,9 +111,7 @@ If you're not using the guided install, follow the instructions for your environ
id="windows-install"
title="Windows"
>
1. Download the `nri-jmx` .MSI installer image from:

[https://download.newrelic.com/infrastructure_agent/windows/integrations/nri-jmx/nri-jmx-amd64-installer.exe](https://download.newrelic.com/infrastructure_agent/windows/integrations/nri-jmx/nri-jmx-amd64-installer.exe)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For docs folks: no idea if it is better to show the url when downloading something or not 😄
I followed the same approach we had for kafka, but the old one might be better

@homelessbirds
Copy link
Contributor

@paologallinaharbur Would you mind signing our CLA one more time? Thanks!

@homelessbirds homelessbirds added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Mar 18, 2024
@homelessbirds homelessbirds self-assigned this Mar 18, 2024
@paologallinaharbur
Copy link
Member Author

@homelessbirds done!

@homelessbirds
Copy link
Contributor

@bradleycamacho can you take a look at this one? Looks like it touches a lot of your work.

@homelessbirds homelessbirds moved this from Hero to triage to In progress in Docs PRs and Issues Mar 18, 2024
@paologallinaharbur
Copy link
Member Author

Any news?

@bradleycamacho
Copy link
Contributor

Hi @paologallinaharbur! Sorry, I didn't notice Sammie's notification earlier. Merging this in now.

@bradleycamacho bradleycamacho merged commit 5652fa2 into newrelic:develop May 8, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants