-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): update kafka docs and related ones #16556
chore(docs): update kafka docs and related ones #16556
Conversation
|
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @paologallinaharbur 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes). |
⏳ Netlify Preview Deployment InformationThis comment will auto update when your preview build is ready |
1 similar comment
⏳ Netlify Preview Deployment InformationThis comment will auto update when your preview build is ready |
@@ -112,9 +111,7 @@ If you're not using the guided install, follow the instructions for your environ | |||
id="windows-install" | |||
title="Windows" | |||
> | |||
1. Download the `nri-jmx` .MSI installer image from: | |||
|
|||
[https://download.newrelic.com/infrastructure_agent/windows/integrations/nri-jmx/nri-jmx-amd64-installer.exe](https://download.newrelic.com/infrastructure_agent/windows/integrations/nri-jmx/nri-jmx-amd64-installer.exe) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For docs folks: no idea if it is better to show the url when downloading something or not 😄
I followed the same approach we had for kafka, but the old one might be better
@paologallinaharbur Would you mind signing our CLA one more time? Thanks! |
@homelessbirds done! |
@bradleycamacho can you take a look at this one? Looks like it touches a lot of your work. |
Any news? |
Hi @paologallinaharbur! Sorry, I didn't notice Sammie's notification earlier. Merging this in now. |
This PR: