Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ray integration docs #16594

Merged
merged 4 commits into from Apr 16, 2024
Merged

Conversation

RamanaReddy8801
Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 commented Mar 20, 2024

Ticket : https://issues.newrelic.com/browse/NR-249391

Description: Ray - created new integration documentation for Ray integration.

Preview image:

screencapture-localhost-8000-docs-infrastructure-host-integrations-host-integrations-list-ray-integration-2024-03-20-12_26_37

Copy link

Hi @RamanaReddy8801 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). If you add any more commits, you can comment netlify build on this PR to update the preview.

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Mar 20, 2024
Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 98271ee
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/661ef1b484604c0008bfe818
😎 Deploy Preview https://deploy-preview-16594--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@homelessbirds homelessbirds added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Mar 20, 2024
@homelessbirds
Copy link
Contributor

We created a ticket for this work for next sprint starting April 1st.

@homelessbirds homelessbirds moved this from Hero to triage to In progress in Docs PRs and Issues Mar 20, 2024
@nbaenam nbaenam self-requested a review April 11, 2024 10:43
nbaenam
nbaenam previously approved these changes Apr 11, 2024
Copy link
Contributor

@nbaenam nbaenam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions! Feel free to take them or leave them🙂

- Ray integration
- New Relic integrations
metaDescription: Install our Ray dashboards and see your ray data in New Relic.
freshnessValidatedDate: never
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date should be updated.

</Step>
<Step>
## Install the Prometheus integration
1. Download the latest Prometheus release from the [Prometheus download page](https://prometheus.io/download/). Select the appropriate version for your operating system and architecture. For Linux, you'll likely choose the linux-amd64 version. Copy the download link for the tarball (`.tar.gz` file).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add ``to linux-amd64, as follows linux-amd64.

# Match the name of your cluster with the name seen in New Relic.
targets:
- description: Ray_Metrics
urls: ["http://<YOUR_HOST_IP>:64747/metrics", "http://<YOUR_HOST_IP>:44217/metrics", "http://<YOUR_HOST_IP>:44227/metrics"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't use < or > if we follow our style guide.

tags:
- Ray integration
- New Relic integrations
metaDescription: Install our Ray dashboards and see your ray data in New Relic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd write Ray instead of ray.

Docs PRs and Issues automation moved this from In progress to Hero to triage Apr 16, 2024
@bradleycamacho bradleycamacho merged commit f56e329 into newrelic:develop Apr 16, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
Docs PRs and Issues
Hero to triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants