Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serverless): deleting lambda containerized images docs #16681

Merged
merged 2 commits into from Mar 27, 2024

Conversation

homelessbirds
Copy link
Contributor

Deleting these docs to be replaced by more accurate representations of our product.

Copy link

Hi @homelessbirds 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). If you add any more commits, you can comment netlify build on this PR to update the preview.

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Mar 26, 2024
Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for docs-website-netlify failed. Why did it fail? →

Name Link
🔨 Latest commit d7de206
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/66036384671f2800080bcf81

@homelessbirds homelessbirds added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Mar 26, 2024
@akristen akristen closed this Mar 27, 2024
@akristen akristen reopened this Mar 27, 2024
@akristen
Copy link
Contributor

akristen commented Mar 27, 2024

@homelessbirds hi hi. for some reason the build failed, but i reopened it and it built fine but didn't refresh the deploy preview box

i can see that netlify/docs-website-netlify/deploy-preview "built" from the details link in the GH checks, but i wanted to x2 check that you meant to delete the /es/[...]newrelic.ini files. I'm not familiar with those and they aren't deleted in the EN, JP, KR files... just ES/PT... Are these meant to be deleted when we remove docs from ES/PT directories? (x2 checking because they're related to PHP area of the docs and the lambda docs are part of serverless)

@homelessbirds homelessbirds merged commit cd9cb88 into develop Mar 27, 2024
37 checks passed
@homelessbirds homelessbirds deleted the sd-delete-containerized-image-docs branch March 27, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
Docs PRs and Issues
Hero to triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants