Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NRQL): address fixes from a #help-documentation request #16811

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

ally-sassman
Copy link
Contributor

Requests:

  • The first is a warning that when FACETing by time, or when using a time function in the WHERE clause, the rate() function will still return data for the entire time range specified. FACET and WHERE do not scope the data down.
  • The second is just a typo. In the last example it should say "over the past half hour" not "over the past hour".

Requests:

* The first is a warning that when [FACETing by time](https://docs.newrelic.com/docs/nrql/nrql-references/nrql-group-results-across-time/#cohorts), or when using a time function in the WHERE clause, the rate() function will still return data for the entire time range specified.  FACET and WHERE do not scope the data down.
* The second is just a typo.  In the [last example](https://docs.newrelic.com/docs/nrql/using-nrql/rate-function/#average-appname-errors) it should say "over the past half hour" not "over the past hour".
@ally-sassman ally-sassman added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Apr 4, 2024
Copy link

github-actions bot commented Apr 4, 2024

Hi @ally-sassman 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). If you add any more commits, you can comment netlify build on this PR to update the preview.

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Apr 4, 2024
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 4d0240b
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/660f25f84e00640008be6e53
😎 Deploy Preview https://deploy-preview-16811--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@rhetoric101 rhetoric101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ally-sassman I inserted on question below, but I also am not seeing any changes related to the PR description that talks about limitations of faceting with time. What that also supposed to be a part of this PR?

@ally-sassman ally-sassman moved this from Hero to triage to In progress in Docs PRs and Issues Apr 4, 2024
Copy link
Contributor

@akristen akristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this change! The initial contributor in our channel never got back to our follow up, so we can prob just close this out.

@akristen akristen moved this from In progress to In review in Docs PRs and Issues Apr 12, 2024
@akristen akristen moved this from In review to Waiting on TW to merge in Docs PRs and Issues Apr 12, 2024
@akristen akristen merged commit 2351272 into develop Apr 12, 2024
17 checks passed
@akristen akristen deleted the nrql-doc-updates branch April 12, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Docs PRs and Issues
Waiting on TW to merge
Development

Successfully merging this pull request may close these issues.

None yet

3 participants