-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NRQL): address fixes from a #help-documentation request #16811
Conversation
Requests: * The first is a warning that when [FACETing by time](https://docs.newrelic.com/docs/nrql/nrql-references/nrql-group-results-across-time/#cohorts), or when using a time function in the WHERE clause, the rate() function will still return data for the entire time range specified. FACET and WHERE do not scope the data down. * The second is just a typo. In the [last example](https://docs.newrelic.com/docs/nrql/using-nrql/rate-function/#average-appname-errors) it should say "over the past half hour" not "over the past hour".
Hi @ally-sassman 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). If you add any more commits, you can comment |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ally-sassman I inserted on question below, but I also am not seeing any changes related to the PR description that talks about limitations of faceting with time. What that also supposed to be a part of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this change! The initial contributor in our channel never got back to our follow up, so we can prob just close this out.
Requests: