Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OMA): fixing OMA docs still in file system #17105

Merged
merged 7 commits into from May 2, 2024
Merged

Conversation

jeff-colucci
Copy link
Contributor

No description provided.

@jeff-colucci jeff-colucci added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Apr 26, 2024
@jeff-colucci jeff-colucci self-assigned this Apr 26, 2024
Copy link

Hi @jeff-colucci 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Apr 26, 2024
Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 9fbe1c7
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/6633b416897c8c0008650164
😎 Deploy Preview https://deploy-preview-17105--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rhetoric101 rhetoric101 moved this from Hero to triage to In progress in Docs PRs and Issues Apr 26, 2024
@austin-schaefer austin-schaefer removed their request for review April 26, 2024 20:35
bradleycamacho
bradleycamacho previously approved these changes May 1, 2024
Copy link
Contributor

@bradleycamacho bradleycamacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeff-colucci this looks good to me!

The merge conflict is a bit of a pain, it's just confused since your PR deletes those files but they've been updated since you created this branch. Just make sure you don't "fix" the conflict the wrong way and keep the translated files on accident!

@jeff-colucci
Copy link
Contributor Author

Merging after prior approval (I only merged develop in as the change since the review)

@jeff-colucci jeff-colucci merged commit c73c24a into develop May 2, 2024
17 checks passed
@jeff-colucci jeff-colucci deleted the oma-cleanup branch May 2, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants